On Tue, 28 Nov 2023 19:30:34 GMT, Naoto Sato <na...@openjdk.org> wrote:

>> It is best practice to zero out the underlying buffer after use.
>
> Naoto Sato has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   corrected fromIndex

Given that the default `JdkConsole` provider implementation is the one that 
uses jline (in `jdk.internal.le` module), should we also do something to zero 
out this data in its implementation too. A brief glance suggests that it too 
uses an internal implementation class called 
`jdk.internal.org.jline.reader.impl.BufferImpl`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16861#issuecomment-1833550541

Reply via email to