On Thu, 30 Nov 2023 14:14:56 GMT, Alexey Semenyuk <[email protected]> wrote:

> Add tests to make sure jpackage emits meaningful error messages when used 
> with invalid app images.
> 
> Added `JPackageCommand.nullableOutputBundle()` function that returns an empty 
> `Optional` instance if it fails to deduce a path to the output bundle from 
> jpackage command line. This is the case when jpackage command is used with 
> `--app-image` cli option and referenced app image directory is missing 
> `.jpackage.xml` file.

Looks good.

-------------

Marked as reviewed by almatvee (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16901#pullrequestreview-1758569694

Reply via email to