On Fri, 1 Dec 2023 19:40:39 GMT, Iris Clark <i...@openjdk.org> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> moved instance fields at the top of the class
>
> src/jdk.internal.le/share/classes/jdk/internal/org/jline/JdkConsoleProviderImpl.java
> line 114:
>
>> 112: return null;
>> 113: } finally {
>> 114: jline.zeroOut();
>
> The location of the `jline `declaration at new line 134 is unfortunate, but
> not a problem this PR needs to resolve. The location makes sense if it was
> only used in `initJLineIfNeeded()` at some point in the past.
Thanks, Iris. Moved those instance fields to the top of the class.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16930#discussion_r1412582527
