On Fri, 1 Dec 2023 21:53:06 GMT, Justin Lu <[email protected]> wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> clarify limitations
>
> src/java.base/share/classes/java/text/MessageFormat.java line 299:
>
>> 297: * the string produced by a {@code ChoiceFormat} in {@code
>> MessageFormat} is
>> 298: * treated as special; occurrences of '{' are used to indicate
>> subformats, and
>> 299: * cause recursion. A limitation to this behavior is that, if a {@code
>> MessageFormat}
>
> @naotoj Please let me know if the added limitations wording reads clearly to
> you. I would rather not have a whole dedicated code example to explain a
> _limitation_, but if needed for better understanding, I can add one.
Do you mean `{@code MessageFormat}{@code FormatElement}`?
Also, I would rather remove "A limitation to this behavior is that," as readers
would know the following explanation explains a limitation.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16891#discussion_r1412620378
