On Mon, 11 Dec 2023 23:17:01 GMT, Naoto Sato <[email protected]> wrote:
>> src/java.base/share/classes/java/util/Locale.java line 301:
>>
>>> 299: * is unparsable, it is ignored. The overriding values of other
>>> properties are not
>>> 300: * checked for syntax or validity and are used directly in the default
>>> Locale.
>>> 301: * (Typically, system property values can be provided using the {@code
>>> -D} command-line
>>
>> Do these last two sentences need to be enclosed in a parentheses? It seems
>> pretty important as it is the main way to override the properties via
>> command-line.
>
> The `-D` command-line option is not a part of the Java SE specification but
> an allowed behavior, so it may not be a normative description here.
Right, I suggested putting that in parentheses. Historically we haven't been
very formal about distinguishing between normative (Java SE) specifications and
informative text that talks about implementations. In this case I felt that
enclosing the text in parentheses and also adding hedging words ("typically")
made it clear that this text isn't normative.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17065#discussion_r1424859379
