On Sat, 16 Dec 2023 16:42:09 GMT, Chen Liang <[email protected]> wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added missing comment
>
> src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java
> line 1519:
>
>> 1517: // double - d2i,i2b d2i,i2s d2i,i2c d2i
>> d2l d2f <->
>> 1518: if (from != to && from != TypeKind.BooleanType && to !=
>> TypeKind.BooleanType) try {
>> 1519: cob.convertInstruction(from, to);
>
> Need an intermediate int if you are converting from long/float/double to
> byte/short/char.
Will fix, thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17108#discussion_r1429794214
