On Sun, 17 Dec 2023 09:42:57 GMT, Alan Bateman <[email protected]> wrote:
>> Valeh Hajiyev has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> updated the javadoc
>
> src/java.base/share/classes/java/util/PriorityQueue.java line 215:
>
>> 213: * Creates a {@code PriorityQueue} containing the elements in the
>> 214: * specified collection. The {@code PriorityQueue} will order its
>> 215: * elements according to the specified comparator.
>
> The wording "will order its elements" is consistent with the other
> constructors but I wonder if "its" might be mis-read to mean the collection
> rather than the queue. If you change it to "will order the priority queue's
> elements" will avoid that.
>
> You'll need to add `@since 23`. Also new tests will need to be added for this
> constructor.
makes sense, updated it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17045#discussion_r1431942707
