On Wed, 13 Dec 2023 20:06:03 GMT, Archie Cobbs <aco...@openjdk.org> wrote:
> One of the three `XMLStreamException` constructors that takes a `Throwable` > fails to pass it to the superclass constructor. > > This simple patch fixes that omission. > > It's worth considering if there is any code out there that is working around > this problem already by invoking `initCause()` manually. If so, that code > would start throwing an `IllegalStateException` after this change. > > So a more conservative fix would be to just add another constructor taking > the same arguments in a different order. But then again that's not much > better than just saying "always use initCause() with the broken constructor", > i.e., don't change anything. > > Hmm. Hello Archie, the changes look fine to me. I see that Joe has approved this change and the CSR too has been approved. I've triggered a CI run to verify there's no unexpected issues. Once that completes, I'll go ahead and sponsor this. ------------- Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17090#pullrequestreview-1800002086
