On Fri, 5 Jan 2024 22:58:36 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Discovered while writing a test for #16513 that >> `ClassSignature.superclassSignature()` does not return a `ClassTypeSig`, yet >> [JVM >> Spec](https://docs.oracle.com/javase/specs/jvms/se21/html/jvms-4.html#jvms-4.7.9.1-4100) >> requires it to be one. This patch adds such a requirement to the accessors, >> factories, and the parsing logic. > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains six commits: > > - Fix a few other invalid signatures > - Merge branch 'master' of https://github.com/openjdk/jdk into > feature/class-signature-elements > - Add extra test cases for new bad class signatures > - Merge branch 'master' into feature/class-signature-elements > - Merge branch 'master' into feature/class-signature-elements > - 8319463: ClassSignature should have superclass and superinterfaces as > ClassTypeSig @asotona Could you review this patch, which fixes some of our API's violation of the JVMS, as shown in the tests? ------------- PR Comment: https://git.openjdk.org/jdk/pull/16514#issuecomment-1879361294
