On Wed, 10 Jan 2024 16:09:14 GMT, Viktor Klang <vkl...@openjdk.org> wrote:

>> Brent Christian has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Add links to new Memory Consistency section in package doc
>
> src/java.base/share/classes/java/lang/ref/Reference.java line 499:
> 
>> 497:      * the reference is removed from the queue by {@link 
>> ReferenceQueue#poll}
>> 498:      * or {@link ReferenceQueue#remove}. An <b><i>unsuccessful</i></b>
>> 499:      * {@code enqueue} call has no memory consistency effects.
> 
> Would it help to say that unsuccessful enqueue calls have no *reliable* or 
> *specified* memory consistency effects?

Yes, I like that phrasing better, thanks

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16644#discussion_r1448025551

Reply via email to