On Tue, 21 Nov 2023 09:12:49 GMT, Viktor Klang <vkl...@openjdk.org> wrote:
>> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >> >> A couple key things we want to be able to say are: >> - `Reference.reachabilityFence(x)` _happens-before_ reference processing >> occurs for 'x'. >> - `Cleaner.register()` _happens-before_ the Cleaner thread runs the >> registered cleaning action. >> >> This will bring Cleaner in line (or close) with the memory visibility >> guarantees made for finalizers in [JLS >> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5): >> _"There is a happens-before edge from the end of a constructor of an object >> to the start of a finalizer (ยง12.6) for that object."_ > > src/java.base/share/classes/java/lang/ref/Reference.java line 497: > >> 495: * or {@link ReferenceQueue#remove}. >> 496: * >> 497: * <p>This method is invoked only by Java code; when the garbage >> collector > > Perhaps something along the lines of: > > Suggestion: > > * <p>This method is only invoked explicitly; when the garbage collector I think the important part to convey is that the GC won't call this method. So how about _just_: <p>When the garbage collector enqueues references it does so directly, without invoking this method. ? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16644#discussion_r1409993103
