On Thu, 11 Jan 2024 16:50:42 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> This test was recently dialled down via JDK-8323002 but it still makes slow >> progress on some test machines, esp. macox-x64-debug builds. The issue is >> that the sampling of the target thread is skewed towards the unmounted case >> so the target thread is disabled from being scheduled and doesn't make >> progress. The test is re-worked to use a barrier so that the main thread and >> target virtual thread run in lock step. This allows the virtual thread to >> make progress at each iteration and also increases the chances of sampling >> the stack trace at around the time that the target thread transitions from >> being unmounted (due to the Thread.yield) and parking while pinned. > > Alan Bateman has updated the pull request incrementally with one additional > commit since the last revision: > > Run in othervm mode Thank you Alan, the changes look good to me. ------------- Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17353#pullrequestreview-1817235395