On Mon, 5 Feb 2024 10:44:59 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> I am sorry, but all I can see is: > > > Just a few questions... > > and then your comment ends. And I can't find any other comment with a list of > questions. Eh? Aren't they in the code review section? But in any case: > Shouldn't this be -pedantic -Wpedantic, and wouldn't this be better > positioned at where HotSpot currently sets -permissive- for Microsoft Visual > C++ (In other words, TOOLCHAIN_CFLAGS_JVM and TOOLCHAIN_CFLAGS_JDK)? The 2 > options are not the same, at least on gcc, and I'm unsure if the same is true > for clang The other concern I had was that there are a ton of disabled warnings added by this change, but I guess that's already been answered by that other reply ------------- PR Comment: https://git.openjdk.org/jdk/pull/17687#issuecomment-1926701211
