On Fri, 9 Feb 2024 11:55:16 GMT, Lance Andersen <lan...@openjdk.org> wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Spell fix for "Contents" >> - Add comments to explain how we temporarily use the 'unknown' tag to >> prevent ZipEntry.setExtra0 from processing the extra field. > > test/jdk/java/util/zip/ZipFile/Zip64SizeTest.java line 114: > >> 112: >> 113: // Make an extra field with the correct size for an 8-byte >> 'uncompressed size' >> 114: // Zip64 field. Temporarily use the 'unknown' tag 0x9902 to >> make > > I would suggest adding a reference to the following in the APPNOTE.TXT to > make clearer where that value came from > >> 4.6.1 Third party mappings commonly used are: > > another suggestion would be to show the CEN here with this change I think > would make it easier for someone who is not as familiar with APPNOTE.TXT The CEN structure is already descibed in the method-level documentation. Would you prefer I move it into the code? Not sure I would like to repeat it, and I think perhaps it's better to have the whole structure in once place, instead of splitting it (since the Zip64 extra corresponds to the CEN header fields). What do you think? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/12948#discussion_r1484246232
