On Thu, 15 Feb 2024 06:29:24 GMT, Christian Stein <cst...@openjdk.org> wrote:
>> Please review this PR that makes the launcher helper keep a reference to the >> executable JAR file active after extracting the name of the main class and >> returning it as Class instance. Now, when loading classes from the JAR file, >> it hasn't to be re-opened. > > Christian Stein has updated the pull request incrementally with two > additional commits since the last revision: > > - Remove `String jarname` from `getMainClassFromJar`'s signature > - Introduce and use dedicated on-close error message Hello Christian, the changes look OK to me. Both the files will need a copyright year update. The JBS issue would need an appropriate noreg label too https://openjdk.org/guide/#noreg ------------- Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17843#pullrequestreview-1887725461
