On Thu, 22 Feb 2024 14:57:05 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:

>> Currently assertEquals has in the failure case sometimes confusing output 
>> like :
>> 
>> java.lang.RuntimeException: VM output should contain exactly one RTM locking 
>> statistics entry for method 
>> compiler.rtm.locking.TestRTMTotalCountIncrRate$Test:🔒 expected 0 to equal 1
>>        at jdk.test.lib.Asserts.fail(Asserts.java:634)
>>        at jdk.test.lib.Asserts.assertEquals(Asserts.java:205)
>> 
>> (I don't think we really expected that for some reason 0 equals 1)
>> This should be improved.
>
> Matthias Baesken has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Adjust COPYRIGHT year info

I think it is a good idea to improve this. I was irritated by that output more 
than once.

Maybe a better message would be ... _"..." is not equal to "..."_ ?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17952#issuecomment-1959680638

Reply via email to