On Tue, 20 Feb 2024 08:29:44 GMT, Emanuel Peter <[email protected]> wrote:
>> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 1716:
>>
>>> 1714: XMMRegister xtmp3, Register
>>> rtmp,
>>> 1715: Register midx, Register
>>> length,
>>> 1716: int vector_len, int vlen_enc)
>>> {
>>
>> I would like to see more descriptive names, where I don't have to
>> reverse-engineer their meaning.
>> What are the pre/post-conditions on `midx`?
>
> I'll rereview after
So xtmp1...3 and rtmp cannot have more descriptive names?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16354#discussion_r1502299116
