On Mon, 26 Feb 2024 16:21:38 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> review comments > > test/jdk/java/foreign/TestLayouts.java line 164: > >> 162: ); >> 163: assertEquals(struct.byteSize(), 1 + 1 + 2 + 4 + 8); >> 164: assertEquals(struct.byteAlignment(), 8); > > Looking at this PR: > https://github.com/openjdk/jdk/pull/18007 > > This test seemed to cover more case before that PR - e.g. a layout generator > was tweaked to exclude long/doubles. I believe revert the test changes now? That doesn't seem to be the right PR link? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18007#discussion_r1503163065
