On Wed, 28 Feb 2024 14:03:58 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> GitHub doesn't allow me to comment on unchanged lines in the PR, but while > reviewing this I noticed 2 things: > > * It looks like http://www.pkware.com/documents/casestudies/APPNOTE.TXT is > now auto redirecting to > https://pkware.cachefly.net/webdocs/APPNOTE/APPNOTE-6.3.9.TXT. I'm not sure > if it's temporary or a permanent thing. I cannot answer that specifically but we need to rely on PKWARE to keep this as accurate as possible. The link has been broken several times by PKWare so I think the best that we can do is keep checking. > * The other thing is we don't seem to have a `@spec` entry in > `src/java.base/share/classes/java/util/zip/package-info.java` pointing to > http://www.pkware.com/documents/casestudies/APPNOTE.TXT. We are pointing to > ZLIB RFC 1950. Do you think we should add a `@spec` entry to point to > http://www.pkware.com/documents/casestudies/APPNOTE.TXT? Of course as a > separate PR. Good Question, let's discuss and handle separately as I don't know the history of why it was not included ------------- PR Comment: https://git.openjdk.org/jdk/pull/18011#issuecomment-1969151426
