On Wed, 6 Mar 2024 21:22:40 GMT, Jan Lahoda <jlah...@openjdk.org> wrote:
>> src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java line
>> 812:
>>
>>> 810: }
>>> 811:
>>> 812: private static void addEnableNativeAccess(ModuleLayer layer,
>>> Set<String> moduleNames, boolean shouldWarn) {
>>
>> The private methods in this class have a short comment to summarise what
>> they do.
>
> I've tried to add a comment here:
> https://github.com/openjdk/jdk/pull/18106/commits/e17cd3722724cbc6aa298f7b789c6574554af6ea
Thanks. I view these changes to ModuleBootstrap to be temporary. We'll need to
create a few follow on issues in JBS, one of which is to update jlink so that
we have the exact set of modules in the run-time image that have been granted
native access.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18106#discussion_r1515838474
