On Thu, 7 Mar 2024 21:00:01 GMT, Ioi Lam <ik...@openjdk.org> wrote: >> A few clean ups: >> >> 1. Rename functions like "`s_loading_full_module_graph()` to >> `is_using_full_module_graph()`. The meaning of "loading" is not clear: it >> might be interpreted as to cover only the period where the artifact is being >> loaded, but not the period after the artifact is completely loaded. However, >> the function is meant to cover both periods, so "using" is a more precise >> term. >> >> 2. The cumbersome sounding `disable_loading_full_module_graph()` is changed >> to `stop_using_full_module_graph()`, etc. >> >> 3. The status of `is_using_optimized_module_handling()` is moved from >> metaspaceShared.hpp to cdsConfig.hpp, to be consolidated with other types of >> CDS status. >> >> 4. The status of CDS was communicated to the Java class >> `jdk.internal.misc.CDS` by ad-hoc native methods. This is now changed to a >> single method, `CDS.getCDSConfigStatus()` that returns a bit field. That way >> we don't need to add a new native method for each type of status. >> >> 5. `CDS.isDumpingClassList()` was a misnomer. It's changed to >> `CDS.isLoggingLambdaFormInvokers()`. > > Ioi Lam has updated the pull request incrementally with one additional commit > since the last revision: > > @dholmes-ora comments -- white spaces and copyright
Marked as reviewed by ccheung (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/18095#pullrequestreview-1923734079
