On Mon, 11 Mar 2024 13:54:06 GMT, Shaojin Wen <d...@openjdk.org> wrote:
>> The current BigDecimal(String) constructor calls String#toCharArray, which
>> has a memory allocation.
>>
>>
>> public BigDecimal(String val) {
>> this(val.toCharArray(), 0, val.length()); // allocate char[]
>> }
>>
>>
>> When the length is greater than 18, create a char[]
>>
>>
>> boolean isCompact = (len <= MAX_COMPACT_DIGITS); // 18
>> if (!isCompact) {
>> // ...
>> } else {
>> char[] coeff = new char[len]; // allocate char[]
>> // ...
>> }
>>
>>
>> This PR eliminates the two memory allocations mentioned above, resulting in
>> an approximate 60% increase in performance..
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix code style
Looks great to me. Sorry for the pings, but we may need @rgiulietti to verify
the math correctness and @cl4es to comment on whether having these 2 separate
code paths or trying to extract a common part is the better approach.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18177#issuecomment-1988546982
