On Tue, 12 Mar 2024 16:26:48 GMT, Naoto Sato <na...@openjdk.org> wrote:

> Adding a table that maps JDK versions and corresponding CLDR releases as an 
> implNote. A draft CSR has also been created.

Irrelevant to this doc change, I happen to notice some of the 
jdk`<version>`-suported-locales docs might have not been updated. For example, 
https://www.oracle.com/java/technologies/javase/jdk20-suported-locales.html had 
"CLDR release 39" rather than 42 as stated here. Similarly 
jdk19-suported-locales.html -> 39 instead of 41, 18 was correctly -> 39, but 17 
-> 35.1, and so on.

src/java.base/share/classes/java/util/spi/LocaleServiceProvider.java line 148:

> 146:  * "SPI" in order for the Java runtime to load them from the classpath.
> 147:  *
> 148:  * @implNote The JDK uses locale data from the Unicode Common Locale 
> Data Repository

The full name may be moved to where the acronym was first used, e.g. "CLDR": 
the Unicode Common Locale Data Repository (CLDR) is a provider based on Unicode 
Consortium's <a href="http://cldr.unicode.org/";>CLDR Project</a>. If you decide 
to do that, then we may use it here to state: The JDK uses CLDR to implement 
locale-sensitive APIs in the java.util and java.text packages.

src/java.base/share/classes/java/util/spi/LocaleServiceProvider.java line 154:

> 152:  * version of CLDR used in each JDK release.
> 153:  * <table class="striped">
> 154:  * <caption style="display:none">Shows JDK releases and supported CLDR 
> versions</caption>

nit: the word "Shows" can be omitted.

-------------

Marked as reviewed by joehw (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18243#pullrequestreview-1931862314
PR Review Comment: https://git.openjdk.org/jdk/pull/18243#discussion_r1521907892
PR Review Comment: https://git.openjdk.org/jdk/pull/18243#discussion_r1521896890

Reply via email to