On Tue, 19 Mar 2024 11:21:14 GMT, Nizar Benalla <d...@openjdk.org> wrote:
>> I added `@since` tags for methods/constructors that do not match the >> `@since` of the enclosing class. >> >> The `write` method already existed in `PrintStream` in earlier versions and >> instances of it could always call this method, since it extends >> `FilterOutputStream` [which has the >> method](https://github.com/openjdk/jdk6/blob/3e49aa876353eaa215cde71eb21acc9b7f9872a0/jdk/src/share/classes/java/io/FilterOutputStream.java#L96). > > Nizar Benalla has updated the pull request incrementally with three > additional commits since the last revision: > > - Revert "fix rest of private/public since tags" > > This reverts commit 2c04a9d8e773616b7b6239335d4e5eb955944ad1. > - Revert "removed unnecessary @ since tags" > > This reverts commit 5da3f0d83d19393eeb3a9da68aac40dd999de660. > - removed unnecessary @ since tags src/java.base/share/classes/javax/crypto/interfaces/DHPublicKey.java line 68: > 66: * > 67: * @return {@inheritDoc java.security.AsymmetricKey} > 68: * @since 22 Hello Nizar, are the removal of `@since` in this PR intentional? I haven't checked all of them, but this specific removal appears incorrect, since this method was indeed introduced in Java 22 as part of https://bugs.openjdk.org/browse/JDK-8318096. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18055#discussion_r1526987579
