On Tue, 2 Apr 2024 08:14:25 GMT, Suchismith Roy <s...@openjdk.org> wrote:
>> I adjust the comments which also answer your question. Please add an >> AIX-only test to verify this behavior. > >> I adjust the comments which also answer your question. Please add an >> AIX-only test to verify this behavior. > > By test you mean provide the use case for pure .a files ? Hello @suchismith1993, > > I adjust the comments which also answer your question. Please add an > > AIX-only test to verify this behavior. > > By test you mean provide the use case for pure .a files ? In the JDK repo, changes like these are backed by jtreg tests https://openjdk.org/guide/#jtreg. So for this change, you would need to add a jtreg test which only runs on AIX (the jtreg documentation explains how to do that) and will exercise the `System.loadLibrary` call for a AIX specific library and verify that the library can be loaded as per the expectations that are set in the changes proposed and finalized in this PR. For example, the test should verify that, after the changes proposed in this PR, calling `System.loadLibrary(<libname>)` on AIX will load from `<libname>.a` if `<libname>.so` is absent. For reference, you can take a look at the existing tests for loadLibrary in the `test/jdk/java/lang/RuntimeTests/loadLibrary` directory. ------------- PR Comment: https://git.openjdk.org/jdk/pull/17945#issuecomment-2031403158
