On Fri, 9 Feb 2024 10:47:08 GMT, Adam Sotona <asot...@openjdk.org> wrote:
>> ClassFile API provides two sets of instructions implementations (bound and >> unbound). >> Unbound implementation of `IncrementInstruction::constant` returns invalid >> value. >> This bug discovered a hole in the ClassFile API test coverage. >> >> This patch provides very simple fix of `IncrementInstruction` >> and more complex fix of the test framework to cover all unbound instruction >> with automated tests. >> >> The test framework fix includes correction of hash calculation of >> instructions in `ClassRecord` and >> two-pass transformation in `RebuildingTransformation`. Second pass has been >> added to discover bugs in unbound-to-unbound instruction conversions. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request incrementally with one additional > commit since the last revision: > > Update test/jdk/jdk/classfile/helpers/RebuildingTransformation.java > > Co-authored-by: Andrey Turbanov <turban...@gmail.com> Looks reasonable. ------------- Marked as reviewed by jlahoda (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17770#pullrequestreview-1988500946
