On Tue, 9 Apr 2024 16:29:07 GMT, Naoto Sato <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Naoto's suggestion - use Instant.MIN and Instant.MAX instead of hardcoded
>> values
>
> src/java.base/share/classes/java/time/temporal/ChronoField.java line 590:
>
>> 588: * This is necessary to ensure interoperation between calendars.
>> 589: * <p>
>> 590: * Range of {@code InstantSeconds} is between {@link Instant#MIN}
>> and {@link Instant#MAX}
>
> Nit: `InstantSeconds` -> `INSTANT_SECONDS`
Hello Naoto, I had used `InstantSeconds` to keep it consistent with how a
similar doc is used for the `EPOCH_DAY` field. Let me know if you still prefer
this to be `INSTANT_SECONDS` and I will update it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18674#discussion_r1558644428
