On Tue, 9 Apr 2024 15:28:08 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:

> We have already good JLI tracing capabilities. But GetApplicationHome and 
> GetApplicationHomeFromDll lack some tracing and should be enhanced.

To me this looks useful, although maybe the overall JLI tracing could be 
revisited.

src/java.base/windows/native/libjli/java_md.c line 326:

> 324:     }
> 325: 
> 326:     JLI_TraceLauncher("GetJREPath - attempt to get JRE location from 
> shared lib of the image\n");

Maybe add a trace also in the USE_REGISTRY_LOOKUP section

-------------

Marked as reviewed by clanger (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18699#pullrequestreview-2003079325
PR Review Comment: https://git.openjdk.org/jdk/pull/18699#discussion_r1567018779

Reply via email to