On Tue, 16 Apr 2024 09:39:02 GMT, Maurizio Cimadamore <[email protected]>
wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update JavaDoc
>
> src/java.base/share/classes/java/lang/foreign/MemorySegment.java line 612:
>
>> 610: * the type of the {@linkplain #heapBase() backing heap storage}.
>> 611: * <p>
>> 612: * This method can be used to ensure, a {@code segment} is
>> sufficiently aligned
>
> I would drop the use of code blocks for `segment` and layout. Also remove the
> comma after "ensure"
Also, "ensure _that_ a memory segment is ..."
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18779#discussion_r1567060697
