On Tue, 23 Apr 2024 06:20:47 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Correct ID in test @bug tag
>
> test/jdk/java/io/ByteArrayOutputStream/WriteToReleasesCarrier.java line 78:
>
>> 76: }
>> 77: } finally {
>> 78: LockSupport.unpark(vthread1);
>
> It might be clearer if you add vthread1.join() after the unpark. It's not
> strictly needed here as scheduler::close will block until the carrier
> terminates so that will guarantee that the virtual thread has unmounted.
Added `vthread1.join()` after the unpark in
1dd59b7bf7aa2087845ad7806a5afbed2b5ea1b5.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18901#discussion_r1577076109
