On Fri, 26 Apr 2024 11:27:35 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
> Looks like your `MethodTypeDescFactories` benchmark is missing form the PR? > Pre-existing. > Does removing the explicit null checks make that much difference for > performance? They are kind of nice for clarity. > It helps startup at least. The redundant array depth check mattered a bit for peak performance, but not much. I don't have a strong opinion really, just find them a bit superfluous when there's a dereference on the next line. > Also, looks like the copyright year still needs to be updated on some of the > files. Fixed, along with using `EMPTY_CLASSDESC` in the `toArray` call. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18971#issuecomment-2079232756
