On Sun, 28 Apr 2024 11:34:57 GMT, Andrew Haley <[email protected]> wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add vectorized and scalar version Float tests checking full 32 bits range
>
> test/hotspot/jtreg/compiler/vectorization/TestRoundVectorFloatAll.java line
> 99:
>
>> 97: System.out.println("Verification");
>> 98: int errn = 0;
>> 99: for (long l = Integer.MIN_VALUE; l <= Integer.MAX_VALUE; l+=ARRLEN) {
>
> Can't you just do the obvious simple thing here?
Not sure if I understand you correctly.
Do you mean just use a while loop? seems it will only test the scalar version
in that way.
> test/hotspot/jtreg/compiler/vectorization/TestRoundVectorFloatAll.java line
> 102:
>
>> 100: for (int i = 0; i < ARRLEN; i++) {
>> 101: input[i] = (int)(l+i);
>> 102: }
>
> What is this array for? As far as i can tell it does nothing useful to batch
> the test results.
Sorry, it's bug.
Also fixed some other issues, e.g. in fact previously the newly added tests are
not run, they still triggered TestRoundVectorFloatRandom.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17753#discussion_r1582907258
PR Review Comment: https://git.openjdk.org/jdk/pull/17753#discussion_r1582907013
