On Sat, 27 Apr 2024 11:58:52 GMT, Viktor Klang <vkl...@openjdk.org> wrote:
>> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> new section for finalizer memviz > > src/java.base/share/classes/java/lang/ref/package-info.java line 157: > >> 155: * <li>The dequeuing of a reference to a >> 156: * {@linkplain Cleaner#register(Object object, Runnable action) >> registered} >> 157: * object, by a Cleaner thread, <i>happens-before</i> that Cleaner >> thread runs > > Are we committing to this? I.e. that there will always be a single Cleaner > thread? (i.e. one could imagine a situation where you have one polling thread > which executes the cleaning action on some other thread?) I'll revert this back to "_the_ Cleaner thread". ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16644#discussion_r1583750541