On Wed, 8 May 2024 05:53:25 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Strengthen tests after 8330998 >> >> https://github.com/openjdk/jdk/pull/18996 now allows us to test >> Console IO better. > > src/java.base/share/classes/java/io/Console.java line 151: > >> 149: /** >> 150: * Writes a string representation of the specified object to this >> console's >> 151: * output stream, terminates the line and then flushes the console. > > Should this specify if the line termination will be platform dependent > character(s) or independent of the platform? That's a good question. I think it should. That `println` method is not specified in terms of `printf` or `format`. Thus, we cannot reduce `println` to, say, `printf("%s%n", obj)`, leaning on `Formatter`'s definition of `%n`: 'n' line separator The result is the platform-specific line separator @stuart-marks, any thoughts on wording? Mind you, if we add any such wording, we'll have to update CSR too. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19112#discussion_r1593742851
