On Tue, 7 May 2024 15:30:25 GMT, Chen Liang <[email protected]> wrote:
>> As discussed on the mailing list >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-June/000381.html, >> BufWriter::asByteBuffer has a behavior not suitable for API and is only used >> by internal StackMapGenerator/StackCounter, so it will be converted to an >> internal API. >> >> Somehow the ByteBuffer needs to be sliced, or StackMapGenerator encounters >> IOOBE. Not sure what the exact cause was. > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains two additional commits since > the last revision: > > - Merge branch 'master' of https://github.com/openjdk/jdk into > fix/asbb-internal > - Convert asByteBuffer to an internal API Looks good, thanks! ------------- Marked as reviewed by asotona (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14736#pullrequestreview-2047286767
