On Thu, 9 May 2024 11:19:14 GMT, Erik Gahlin <egah...@openjdk.org> wrote:
>> Hi, >> >> Could I have a review of a change that moves the jdk.FileRead and >> jdk.FileWrite events to java.base to remove the use of the ASM >> instrumentation. >> >> Testing: jdk/jdk/jfr >> >> Thanks >> Erik > > Erik Gahlin has updated the pull request incrementally with one additional > commit since the last revision: > > Move methods src/java.base/share/classes/sun/nio/ch/FileChannelImpl.java line 419: > 417: > 418: private long implWrite(ByteBuffer[] srcs, int offset, int length) > throws IOException > 419: { Style nit here, the "{" can move to the end of L418. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19129#discussion_r1597461653