On Wed, 15 May 2024 06:30:35 GMT, Jaikiran Pai <[email protected]> wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Replace SimpleImmutableEntry constructor with Map.entry() factory method.
>
> src/java.base/share/classes/java/util/random/package-info.java line 85:
>
>> 83: * Then one can choose a specific implementation by giving the name of a
>> generator
>> 84: * algorithm to the static method {@link RandomGenerator#of}, in which
>> case no
>> 85: * seed is specified by the caller:
>
> Perhaps reword this to:
>
>
>> ... in which case a {@code RandomGenerator} is constructed without any seed
>> value:
An already existing issue in the specification in this file is that, a few
lines below, we note that:
> <p> There are three groups of random number generator algorithm provided in
> Java: the Legacy group, the LXM group, and the Xoroshiro/Xoshiro group.
The "three" groups is misleading I think, since both later in the table as well
as the `group()` method implementation on `RandomGeneratorFactory`, we return
four distinct values "Legacy", "LXM", "Xoroshiro" and "Xoshiro". Should we
reword this part of the documentation to remove the mention of "three"?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19212#discussion_r1601022606
