On Thu, 30 May 2024 16:15:22 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> wrote:
> This PR restores a var handle cache in `Utils::makeSegmentViewVarHandle`. The > cache was moved to `ValueLayouts::varHandle` as part of > [pull/19251](https://git.openjdk.org/jdk/pull/19251), on the basis that we > want to optimize the common case like: > > > ValueLayout layout = ... > layout.varHandle().get(...) > > > And that caching more complex var handles didn't seem to add value, given > that, for these var handles, the logic in `LayoutPath` needs to adapt the > returned var handle anyways. > > But, `TestAccessModes` revealed a different picture - w/o any cache in > `Utils` the test end up allocating 8963 var handle instances (instead of just > 4), in each of the 4 runs the test includes. While this is admittedly a > stress test, it seems nice to restore the level of sharing we had before > [pull/19251](https://git.openjdk.org/jdk/pull/19251). This pull request has now been integrated. Changeset: e99f6a65 Author: Maurizio Cimadamore <mcimadam...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/e99f6a65a8307e6b31a08a677914dfd20d46687f Stats: 27 lines in 2 files changed: 24 ins; 0 del; 3 mod 8333236: Test java/foreign/TestAccessModes.java is timing out after passing Reviewed-by: jvernee ------------- PR: https://git.openjdk.org/jdk/pull/19485
