On Sat, 1 Jun 2024 05:18:17 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this test-only change which updates a couple of >> places in the test to use `try-with-resource`? >> >> As noted in https://bugs.openjdk.org/browse/JDK-7022325 this change should >> prevent leaking of resources in case there's any failure in the test. The >> test continues to pass with this change. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > convert the test to junit Hello Lance, I have now updated the PR to convert this test to junit test. While at it, I have also cleaned up the code to use `java.nio.file.Path` and use the jtreg scratch directory for the directories and the jar file this test creates. That way, we don't have to manually delete the directories when done. I have verified that the changes don't change the semantics of what was being tested in this test, which was a regression test for https://bugs.openjdk.org/browse/JDK-6374379. The test continues to pass with these change in our CI against all platforms. ------------- PR Comment: https://git.openjdk.org/jdk/pull/19492#issuecomment-2143307371
