On Sat, 1 Jun 2024 05:20:24 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review feedback: use Reference::refersTo consistently > > test/jdk/java/util/logging/LogManager/Configuration/updateConfiguration/HandlersOnComplexResetUpdate.java > line 219: > >> 217: } >> 218: WeakReference<Logger> barRef = new >> WeakReference<>(Logger.getLogger("com.bar"), queue); >> 219: if (!barRef.refersTo(barChild.getParent())) { > > Hello Daniel, since `refersTo()` is the preferred API in cases like this, > should this same change be done in the other `HandlersOnComplexUpdate` test > that's being updated in this PR? Good point. Updated. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19503#discussion_r1626196539