On Tue, 11 Jun 2024 11:35:28 GMT, Shaojin Wen <d...@openjdk.org> wrote:
>> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into >> primitive arrays by combining values into larger stores. >> >> This PR rewrites the code of appendNull and append(boolean) methods so that >> these two methods can be optimized by C2. > > Shaojin Wen has updated the pull request incrementally with one additional > commit since the last revision: > > revert Can you make this stand-alone reproducer even more stand alone, so that your different implementations are available as a choice? I don't want to have to check out different versions of your changes in the PR. Maybe we can just focus on a single example for now (appendBoolLatin1 ?), so that we can learn together what is going wrong in that case. Then you can take those learnings and analyze the other cases yourself ;) ------------- PR Comment: https://git.openjdk.org/jdk/pull/19626#issuecomment-2162306966
