On Wed, 12 Jun 2024 20:48:41 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Please review this patch that fixes a critical issue that breaks some Proxy >> usages. >> >> Since the problematic patch from before cannot be backed out, this patch >> aims to emulate the old behavior before. A diff between before the >> problematic patch and this patch is available at >> https://gist.github.com/7565b2091008f561eb0ada019bc5e517, generated by >> running `git diff 326dbb1b139dd1ec1b8605339b91697cdf49da9a -- >> src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java`. > > Chen Liang has updated the pull request incrementally with three additional > commits since the last revision: > > - Fix bad stack map frame > - Forgot to write field > - Try to align with previous code Once a PR is in review doing a bunch of renames hides the real change in a bunch of inconsequential changes and can extend the review. The "Ce" suffix would read better as "CE". src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java line 95: > 93: > 94: private static final String > 95: NAME_LOOKUP_ACCESSOR = "proxyClassLookup"; Join these if there's only 1. ------------- Changes requested by rriggs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19615#pullrequestreview-2114238459 PR Review Comment: https://git.openjdk.org/jdk/pull/19615#discussion_r1637104525
