On Thu, 6 Jun 2024 13:24:06 GMT, Chen Liang <[email protected]> wrote:
>> Adam Sotona has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - reverted static initialization of ConstantPoolBuilder and CP entries
>> - fixed naming conventions
>
> src/java.base/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java
> line 566:
>
>> 564:
>> 565: static ClassDesc implClassDesc(Class<?> cls) {
>> 566: return cls.isHidden() ?
>> ReferenceClassDescImpl.ofValidatedBinaryName(cls.getName())
>
> I recommend just returning null or a dummy value if the cls is hidden; in
> this case, implMethodClassDesc can safely be null, as implementation must go
> through condy.
Relevant issue:
- https://github.com/openjdk/jdk/pull/18810
[JDK‑8330467]: https://bugs.openjdk.org/browse/JDK-8330467
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17108#discussion_r1637204601
