On Fri, 14 Jun 2024 10:39:45 GMT, Ferenc Rakoczi <[email protected]> wrote:
>> This PR removes some unnecessary conversions between byte arrays and long
>> arrays during SHA3 digest computations.
>
> Ferenc Rakoczi has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Accept more review suggestions
src/java.base/share/classes/sun/security/provider/SHA3.java line 137:
> 135: asLittleEndian.set(out, ofs, state[numLongs - 1]);
> 136: } else {
> 137: asLittleEndian.set(byteState, 0, state[numLongs - 1]);
So, is the performance better placing the `byteState` declaration up there at
line 111 instead of here? It's only used in this block...
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19632#discussion_r1640180265
