On Mon, 17 Jun 2024 09:19:22 GMT, Adam Sotona <asot...@openjdk.org> wrote:

>> Chen Liang has updated the pull request incrementally with two additional 
>> commits since the last revision:
>> 
>>  - I am a dumbass
>>  - Retain strict flag for Method, even though it's obsolete
>
> `javap` should never silently ignore erroneous class file content.
> If the flag value violates JVMS - it should be reported as an error and 
> `javap` should reflect that in the return value.
> On the other hand `javap` should handle such situations, provide relevant 
> error message and continue with the report.
> It is similar case as `javap` detection of inappropriate CP entry types.

@asotona Thanks for the note, I have updated the code so javap now behaves like 
your suggestion.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19708#issuecomment-2173462470

Reply via email to