On Mon, 10 Jun 2024 12:29:32 GMT, Pavel Rappo <pra...@openjdk.org> wrote:

> Please review this fix for an intermittent test failure.
> 
> On some configurations, the default `expect` timeout of 10 seconds is 
> insufficient. It is increased to 20; it's hard to imagine a configuration for 
> which that new value would still be insufficient, but we'll see.
> 
> Aside from that, test-generated diagnostics are improved: the version of the 
> `expect` command and the duration of each test method are recorded. 
> `output.exp` is modified for robustness and clear indication of the timeout 
> condition.
> 
> I was reminded, out-of-band, that test timeouts should be scaled with 
> `test.timeout.factor`. I propose to integrate this PR first and then 
> separately update all the affected tests to scale their `expect` timeouts.

This pull request has now been integrated.

Changeset: 1b1dba80
Author:    Pavel Rappo <pra...@openjdk.org>
URL:       
https://git.openjdk.org/jdk/commit/1b1dba8082969244effa86ac03c6053b3b0ddc43
Stats:     69 lines in 3 files changed: 63 ins; 2 del; 4 mod

8333358: java/io/IO/IO.java test fails intermittently

Reviewed-by: naoto

-------------

PR: https://git.openjdk.org/jdk/pull/19627

Reply via email to