On Thu, 20 Jun 2024 18:21:41 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> reflect review comments > > src/java.base/share/classes/sun/util/resources/CurrencyNames.properties line > 516: > >> 514: zmk=Zambian Kwacha >> 515: zwd=Zimbabwean Dollar (1980-2008) >> 516: zwg=Zimbabwe Gold > > It's interesting to see the difference `Zimbabwe` and `Zimbabwean` here. The > latter is from CLDR and the name for ZWG is not yet available, so we may need > to pull the name from CLDR later. I see your point. CLDR takes precedence over ISO4217 regarding currencies here? > src/java.base/share/data/currency/CurrencyData.properties line 585: > >> 583: ZM=ZMW >> 584: # ZIMBABWE >> 585: ZW=ZWL;2024-08-31-22-00-00;ZWG > > JDK switches the currency at the beginning of the transition period. So in > this case, it's 6/25. So we don't need to even specify the transition at all, > as the next build drop is beyond that date. Good to know. Removed the cutover dates. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19813#discussion_r1648013380 PR Review Comment: https://git.openjdk.org/jdk/pull/19813#discussion_r1648013361