On Sun, 23 Jun 2024 06:19:17 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> fabioromano1 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed unused import > > Thanks for contributing to the OpenJDK! > What tests did you run for this change? How did you compare the performance > of the new vs the original method? How can we reproduce the results? > > Please add a JMH benchmark for your changes. JMH benchmarks are the standard > method of evaluating performance improvements. @djelinski I ran the tests for BigInteger's square root and remainder in the test class [BigIntegerTest.java](https://github.com/openjdk/jdk/blob/master/test/jdk/java/math/BigInteger/BigIntegerTest.java). ------------- PR Comment: https://git.openjdk.org/jdk/pull/19710#issuecomment-2184909896
