On Thu, 27 Jun 2024 11:19:44 GMT, lingjun-cg <d...@openjdk.org> wrote:
>> src/java.base/share/classes/java/text/StringBufFactory.java line 45:
>>
>>> 43: }
>>> 44:
>>> 45: private static class StringBufferImpl implements Format.StringBuf {
>>
>> The implementations may be more concise as a `record class`
>
> I know little about `record class`, it seems `record class` is help to model
> data aggregation, but here it act as a proxy class.
Yes, but since these implementations are just proxy classes, I think it is even
more the reason to make them as simple/concise as possible since we don't care
too much about what they do. (Since for most part it's the same as normal
StringBuf/Bldr)
Either is fine here, we can stick with as is if you prefer.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19513#discussion_r1657646453
