On Thu, 27 Jun 2024 18:31:30 GMT, Justin Lu <j...@openjdk.org> wrote:
>> lingjun-cg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8333396: Performance regression of DecimalFormat.format > > test/micro/org/openjdk/bench/java/text/DefFormatterBench.java line 72: > >> 70: 1.23, 1.49, 1.80, 1.7, 0.0, -1.49, -1.50, 9999.9123, 1.494, >> 1.495, 1.03, 25.996, -25.996 >> 71: }; >> 72: date = new Date(); > > Not sure how others feel, but I think it is probably best that the benchmark > is a separate test file, as opposed to being added to an existing benchmark. > Otherwise if we stick with this file, copyright needs to be updated. +1 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19513#discussion_r1657744470
